On Thu, 30 Oct 2025 16:17:21 GMT, Michael McMahon <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace wrapper's `preTerminationCallback` argument with a method to be >> extended > > src/java.net.http/share/classes/java/net/http/HttpClient.java line 315: > >> 313: * implementation applies it to the entire connection phase, >> from the >> 314: * moment a connection is requested until it is established. The >> 315: * elapsed time includes any SSL/TLS handshake. > > Suggestion: > > * A connection timeout applies to the entire connection phase, from > the > * moment a connection is requested until it is established. The > * elapsed time includes any SSL/TLS handshake. > > This is a suggested simplification. If acceptable it could be applied to the > same doc pattern elsewhere. Improved as suggested in cd74d1dca84. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27469#discussion_r2486291437
