On Wed, 8 Oct 2025 15:02:02 GMT, Alan Bateman <[email protected]> wrote:

>> Josiah Noel has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update module-info.java
>
> src/java.base/share/classes/module-info.java line 282:
> 
>> 280:         java.net.http,
>> 281:         jdk.naming.dns,
>> 282:         jdk.httpserver;
> 
> It would be good if we could avoid giving the jdk.httpserver module access to 
> the sun.net.* package.
> 
> @dfuch @Michael-Mc-Mahon Are you sure that net.properties is the right place 
> for this?

@AlanBateman I hadn't realised that the HttpServer didn't already have access 
to `sun.net.*` - and I agree that it would be better if we did not add such an 
access. That said - the new property is a compatibility property - and 
documenting in module-info seemed a bit too much - so out of the way in 
`net.properties` seemed like an appealing place to add it. 

Another possibility could be to document it only in the release notes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27652#discussion_r2414209436

Reply via email to