On Tue, 7 Oct 2025 16:10:20 GMT, Josiah Noel <[email protected]> wrote:
>> Now ExchangeImpl will default to having a separate attribute map for the >> request duration. > > Josiah Noel has updated the pull request incrementally with one additional > commit since the last revision: > > require non null I agree with @Michael-Mc-Mahon that we will need a test to verify both old (with property set) and new behavior. Also this change will require a CSR and release notes. Otherwise the proposed solution looks good. I believe it meets what a user reading the documentation would expect: get/set attributes on context get/set attributes for the whole context and may be observed by all exchanges that operate on this context. get/set attribute on the exchange get/set attributes whose scope is limited to that particular exchange. This was a long standing issue and I'm happy to see it fixed. Thanks for driving that @SentryMan and @Michael-Mc-Mahon ! ------------- PR Review: https://git.openjdk.org/jdk/pull/27652#pullrequestreview-3314681395
