On Tue, 7 Oct 2025 09:22:39 GMT, Michael McMahon <[email protected]> wrote:
>> Josiah Noel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> require non null
>
> src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java line 65:
>
>> 63: private static final boolean perExchangeAttributes =
>> 64: !System.getProperty("jdk.httpserver.attributes", "")
>> 65: .equals("context");
>
> The property will have to be documented somewhere such as the jdk.httpserver
> module-info. But, I'm wondering if fairly obscure properties like this might
> be better off "buried" in the net.properties config file. I think there's a
> case for putting all such "compatibility" flags somewhere out of the way like
> that. If we were to do that, you would need to access the property using
> `sun.net.NetProperties`.
>
> Any other views on this?
I can switch to `sun.net.NetProperties` if you so desire.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27652#discussion_r2412350550
