On Wed, 15 Jan 2025 10:50:55 GMT, Volkan Yazıcı <d...@openjdk.org> wrote:
>> Adds `limiting()` factory methods to
>> `HttpResponse.Body{Handlers,Subscribers}` to handle excessive server input
>> in `HttpClient`. I would appreciate your input whether `discardExcess`
>> should be kept or dropped. I plan to file a CSR once there is an agreement
>> on the PR.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove concurrency measures (methods are accessed serially due to the
> Reactive Streams spec)
src/java.net.http/share/classes/java/net/http/HttpResponse.java line 757:
> 755: * and passed to the given downstream {@code BodyHandler}}
> 756: * <p>
> 757: * If the number of bytes received exceeds the maximum number of
> bytes
Although the `BodyHandlers` and `BodySubscribers` already note that they are
applicable for reponse bodies, should we be adding any clarification in this
new API, stating that the limit applies only to the body after the headers are
read (however big those may be in bytes)?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23096#discussion_r1916751413
