On Tue, 14 Jan 2025 20:46:14 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Make `LimitingSubscriber` stateful >> - Improve Javadoc >> - Replace `IllegalStateException` with an `IOException` >> - Remove `discardExcess` argument > > Thanks for taking into account the feedback! Some more comments. @dfuch, 144ce26a2c0889b9b8b31d2a9ae67c3778f7715b removes concurrency measures, since [the Reactive Streams specification](https://github.com/reactive-streams/reactive-streams-jvm) states that publishers MUST access subscriber methods serially – run this through @viktorklang-ora. I will further try implementing [Reactive Streams TCK](https://github.com/reactive-streams/reactive-streams-jvm/tree/master/tck-flow) tests for the new subscriber. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23096#issuecomment-2592307881
