On Mon, 25 Nov 2024 08:08:44 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor code comment update in the test
>
> src/java.base/unix/classes/jdk/internal/loader/FileURLMapper.java line 82:
>
>> 80: return false;
>> 81: } else {
>> 82: File f = new File(s);
>
> Lots of unrelated cleanup in this file, but okay.
Right, I was considering of not doing it, but the number of such lines didn't
seem too many, so decided to include it. If you and others lean towards leaving
the formatting clean up out of this, then I will update the PR accordingly.
> I think renaming "jaros" to "jos" would make it a bit easier to read.
Done.
> Also personally I would drop the uses of final from the try statement, only
> because there it adds noise when looking at the 3 resources in the statement.
Understood. I have updated the PR to remove them from the `try` statement.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22351#discussion_r1856074510
PR Review Comment: https://git.openjdk.org/jdk/pull/22351#discussion_r1856067995
