On Mon, 25 Nov 2024 08:11:21 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/net/www/ParseUtil.java line 176:
>>
>>> 174: * @throws IllegalArgumentException if {@code s} could not be
>>> decoded
>>> 175: */
>>> 176: public static String decode(String s) throws
>>> IllegalArgumentException {
>>
>> I'm not sure if you meant to add this or not but "throws IAE" is not needed,
>> usually don't put unchecked exceptions in the throws.
>
> Hello Alan, that was intentional to be more prominently visible, but I'll
> remove it and will just retain `@throws` javadoc tag that I added as part of
> this change.
Done - I've updated the PR to remove the throws clause from the method
signature.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22351#discussion_r1856064670
