On Tue, 19 Nov 2024 16:21:11 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like >> from the `jdk.sctp` module. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8344446: Address reviewer comments src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 1085: > 1083: } > 1084: > 1085: @SuppressWarnings({"restricted"}) Nit, you don't need the braces. src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java line 243: > 241: > 242: IOUtil.configureBlocking(newfd, true); > 243: return new SctpChannelImpl(provider(), newfd); You can also delete line 216. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848689784 PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1848691300