On Tue, 19 Nov 2024 01:17:55 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like > from the `jdk.sctp` module. Marked as reviewed by alanb (Reviewer). src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpNet.java line 94: > 92: set = new HashSet<>(saa.length); > 93: for (SocketAddress sa : saa) > 94: set.add(sa); It would be nice if this could be changed to `Set.of(saa)` but SctpChannel::getAllLocalAddresses doesn't specify anything about the set, so in theory there may be code that modifies the set, in which case what you have is okay. ------------- PR Review: https://git.openjdk.org/jdk/pull/22225#pullrequestreview-2444490790 PR Review Comment: https://git.openjdk.org/jdk/pull/22225#discussion_r1847777427
