On Thu, 26 Sep 2024 17:00:18 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >> comment on the JBS issue for the reason why they were not included. >> >> The following files were removed, >> >> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html >> - Test runner is no longer an Applet, so not needed >> - test/jdk/sun/net/www/ParseUtil_6380332.java >> - Outdated test that checks a SunTea applet >> - test/jdk/java/net/Socket/SocketImplTest.java >> - An old Applet test missing Jtreg tags. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > review: replace last control panel instance with Settings app `test/jdk/sun/net/www/ParseUtil_6380332.java`: shouldn't we actually keep this test? I see that the code in ParseUtil which is tested here is still there, and I don't think we'd want to touch ParseUtil given potential compatibility issues that might arise. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21096#issuecomment-2377495252
