On Wed, 25 Sep 2024 22:06:55 GMT, Justin Lu <j...@openjdk.org> wrote:

>> Please review this PR which removes usages of Applet within the corelibs 
>> tests.
>> 
>> Most changes are removed comments/updated var names. The JBS issue lists 
>> more files than the ones included in this pull request, please see the 
>> comment on the JBS issue for the reason why they were not included.
>> 
>> The following files were removed,
>> 
>> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html
>>   - Test runner is no longer an Applet, so not needed
>> - test/jdk/sun/net/www/ParseUtil_6380332.java
>>   - Outdated test that checks a SunTea applet
>> - test/jdk/java/net/Socket/SocketImplTest.java
>>   - An old Applet test missing Jtreg tags.
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   restore DefaultTimeZoneTest.java as a manual test using PassFailJFrame

test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 29:

> 27:  * @summary Ensure that Java detects the platform time zone correctly, 
> even
> 28:  * if changed during runtime. Also ensure that the system time zone 
> detection code
> 29:  * detects the "Automatically adjust clock for daylight saving changes" 
> setting

Probably taking this opportunity, changing the wording/instructions aligned 
with "Settings app", instead of deprecated "Control Panel" would be good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21096#discussion_r1776065785

Reply via email to