> Can I please get a review of this change which updates the specification of a > few methods in `java.net.Socket` and `java.net.ServerSocket` classes to > specify the `IOException` that the implementation currently already throws? > > This is merely a doc update and doesn't change the implementation. > > Given that these exceptions can now be asserted, a new jtreg test has been > introduced to verify the exceptions thrown from these APIs. The test passes. > tier testing is currently in progress. I'll open a CSR shortly.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: add Joe's suggestion to the close() methods ------------- Changes: - all: https://git.openjdk.org/jdk/pull/20268/files - new: https://git.openjdk.org/jdk/pull/20268/files/079c5f36..1fb30002 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=20268&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20268&range=03-04 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/20268.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20268/head:pull/20268 PR: https://git.openjdk.org/jdk/pull/20268
