On Sat, 20 Jul 2024 16:49:09 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which updates the specification of >> a few methods in `java.net.Socket` and `java.net.ServerSocket` classes to >> specify the `IOException` that the implementation currently already throws? >> >> This is merely a doc update and doesn't change the implementation. >> >> Given that these exceptions can now be asserted, a new jtreg test has been >> introduced to verify the exceptions thrown from these APIs. The test passes. >> tier testing is currently in progress. I'll open a CSR shortly. > > Jaikiran Pai has updated the pull request incrementally with two additional > commits since the last revision: > > - reduce usage of "if" in the throws clause > - simplify the test Thank you Alan for the review and inputs on the spec and the test. The CSR is now ready for review https://bugs.openjdk.org/browse/JDK-8336868. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20268#issuecomment-2242230920
