On Fri, 10 May 2024 03:53:12 GMT, Nizar Benalla <d...@openjdk.org> wrote:
>> Please review this simple change, aiming to fix current uses of `@since` in >> the source code >> -The constructor >> BasicAuthenticator(java.lang.String,java.nio.charset.Charset) needs an >> `@since 14` instead of 9. >> -com.sun.net.httpserver.spi: package-info.java does not contain an `@since`. >> Thanks in advance. > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > fix copyright headers Marked as reviewed by alanb (Reviewer). The HTTP server was added in JDK 6. The 2-arg constructor was added to BasicAuthenticator via JDK-8199849 in JDK 14. So I think this looks right. ------------- PR Review: https://git.openjdk.org/jdk/pull/19168#pullrequestreview-2049278013 PR Comment: https://git.openjdk.org/jdk/pull/19168#issuecomment-2103897918
