On Fri, 10 May 2024 02:13:56 GMT, Nizar Benalla <d...@openjdk.org> wrote:

> Please review this simple change, aiming to fix current uses of `@since` in 
> the source code
> -The constructor 
> BasicAuthenticator(java.lang.String,java.nio.charset.Charset) needs an 
> `@since 14` instead of 9.
> -com.sun.net.httpserver.spi: package-info.java does not contain an `@since`.
> Thanks in advance.

src/jdk.httpserver/share/classes/com/sun/net/httpserver/spi/HttpServerProvider.java
 line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2023, Oracle and/or its affiliates. All rights 
> reserved.

Seems you changed the header of the wrong file

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19168#discussion_r1596214249

Reply via email to