On Thu, 25 Apr 2024 14:40:36 GMT, robert engels <d...@openjdk.org> wrote:

>> I’m on mobile now so I haven’t looked at the api - but I think adding 
>> default methods like
>> 
>> sendResponseHeadersNoContent(int code)
>> 
>> and OutputStream sendResponseHeadersChunked(int code)
>> 
>> possibly sendResponeWithContent(int code, byte[] data) would also be helpful 
>> and cut down to n a lot of usage problems. 
>> 
>> would also make the api easier to use.
>
> I am more than willing to work on an API change PR to add these methods. It 
> is an abstract class, so they could collide with existing code, but I am 
> guessing it is a trivial fix if it does, and it would break at compile time 
> not runtime.
> 
> adding protected constants to the HttpExchange abstract class seems trivially 
> safe.

I created a PR for the api changes https://github.com/openjdk/jdk/pull/18955

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579747981

Reply via email to