On Thu, 25 Apr 2024 13:29:25 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> I think a better solution would be to add a constant to the api class - >> rather than adding comments everywhere. E.g NO_CONTENT=-1 and >> UNLIMITED_CONTENT=0 or INDETERMINENT_CONTENT=0, or CHUNKED_CONTENT=0 > >> I think a better solution would be to add a constant to the api class - >> rather than adding comments everywhere. E.g NO_CONTENT=-1 and >> UNLIMITED_CONTENT=0 or INDETERMINENT_CONTENT=0, or CHUNKED_CONTENT=0 > > That's not a bad idea. I am doing a small update to the API under another bug > id and I might include that in it. I kind of agree that adding comments might > be overkill. We could probably update a lot of the tests mechanically to use > these symbolic names afterwards. I’m on mobile now so I haven’t looked at the api - but I think adding default methods like sendResponseHeadersNoContent(int code) and OutputStream sendResponseHeadersChunked(int code) would also make the api easier to use. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579486672
