> The implementation of `BodySubscribers.ofFile` does not correctly handle the > case of a short gathering write. The write should be retried until all the > bytes have been written to the underlying file. > > This is generally not an issue that would occur very frequently, since the > `IOV_MAX` is commonly 1024 on Mac/Linux, and 16 on Windows. However, it is > clearly a bug, and should be fixed.
Chris Hegarty has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: - Merge branch 'master' into 8299015_http_ofFile - revert and use simple hasRemaining loop - fix catch - retry - another Math.addExact - move into the try - use Math::addExact - review comments: 1) remove MAX_INT restriction, and 2) check 0 write - Initial changes ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11722/files - new: https://git.openjdk.org/jdk/pull/11722/files/987aabaf..2aea8f01 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11722&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11722&range=05-06 Stats: 3104 lines in 162 files changed: 2024 ins; 612 del; 468 mod Patch: https://git.openjdk.org/jdk/pull/11722.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11722/head:pull/11722 PR: https://git.openjdk.org/jdk/pull/11722
