On Tue, 20 Dec 2022 14:53:11 GMT, Chris Hegarty <che...@openjdk.org> wrote:

>> The implementation of `BodySubscribers.ofFile` does not correctly handle the 
>> case of a short gathering write. The write should be retried until all the 
>> bytes have been written to the underlying file.
>> 
>> This is generally not an issue that would occur very frequently, since the 
>> `IOV_MAX` is commonly 1024 on Mac/Linux, and 16 on Windows. However, it is 
>> clearly a bug, and should be fixed.
>
> Chris Hegarty has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix catch

Tests came back green. LGTM!

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11722

Reply via email to