On Wed, 22 Jun 2022 06:09:39 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review for this change which adds a utility to the JDK > test library to help launch the JWebServer? As noted in the JBS issue, this > utility does the necessary work to make sure when the `launch()` method > returns, the jwebserver is ready to receive requests. This helps remove a lot > of boilerplate code from individual tests. > > As part of this commit, the existing `MaxRequestTimeTest` has been migrated > to use this new utility. This existing test continues to pass with this > change. > > tier1, tier2 and tier3 testing passed without any related issues. If a test needs an "in-process" HTTP server then it is easy to use the com.sun.net.httpserver API directly or use ToolProvider to find jwebserver. So I think the use-case you are looking at is JDK tests that want a HTTP server in a separate process, is that right? It's important that such tests need to be able to clean up. If I read the proposal correctly then they must call Process:destroy, is that right? ------------- PR: https://git.openjdk.org/jdk/pull/9232
