Hi All,
Please find the latest
webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.5/index.html).
Only change with the previous wrev(04) is i removed "socket type" as
Alan suggested and used the default constructor (Set<SocketOption<?>>
options = new HashSet<>();) in ExtendedSocketOptions.java
Thanks,
Vyom
On Sunday 13 May 2018 12:37 PM, Alan Bateman wrote:
On 12/05/2018 10:21, vyom tewari wrote:
:
Thanks for review, please find the updated
webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.4/index.html).
I've skimmed through this webrev.
The spec for the new options mostly look good but all three include
"The exact semantics of this socket option are socket type and system
dependent". I assume "socket type" should be dropped from this as
these are TCP options. Maybe you can borrow text from the TCP_NODELAY
option where it has the statement "The socket option is specific to
stream-oriented sockets using the TCP/IP protocol".
The changes to the NetworkChannel implementations look okay. The
changes to the NIO tests looks okay too but would be good if you could
keep the formatting consistent with the existing code if you can.
Ivan had good comments so I didn't spent as much time on that code and
it seems very reviewed.
-Alan.
