On 11 May 2018, at 01:04, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 10/05/2018 16:21, vyom tewari wrote: >> Hi, >> >> Please find the latest >> webrev(http://cr.openjdk.java.net/~vtewari/8194298/webrev0.2/index.html) >> ... > It would be better if the channel implementation didn't static import > ExtendedSocketOptions.getInstance as that is a very generic method method > name. As I mentioned previously, you could simplify all these usages if you > add the following to sun.net.ext.ExtendedSocketOption > static Set<SocketOption<?>> options(int type) { return > getInstance().options(type)); }
+1 > A minor comment on tests is that they can use List.of instead of > Arrays.asList. +1 Otherwise, this looks very good. -Chris. P.S. A separate issue, but when reviewing this it reminded me that we should deprecate-for-removal jdk/net/Sockets.java. It’s functionality is already supported by a standard API.
