On 04/11/14 10:51, Alan Bateman wrote:
On 04/11/2014 10:44, Michael McMahon wrote:
Could I get the following small change reviewed please?
http://cr.openjdk.java.net/~michaelm/8062744/webrev.1/
In JDK 9 the problem only affects the Socket.supportedOptions() method,
but the same change is needed in 8 to allow the IP_TOS option to be set
in a ServerSocket.
The change looks okay but for the test then it might be better to
update the existing test java/net/SocketOption/OptionsTest.java.
-Alan.
Thanks Alan. How about I just split the test and check the option
setting behavior in OptionsTest.java
which doesn't have any reference to the jdk.net.Sockets APIs and then
check the Sockets.supportedOptions()
method in the new test?
Michael
