On 17/01/2014 10:39, Tristan Yan wrote:
Agree, reset timeout should be better move
http://cr.openjdk.java.net/~tyan/JDK-8031666/webrev.01/
Thank you
Tristan

This looks okay but I just wonder if we also need to adjust the tolerance in checkTime. As I read it then it checks allows for +/- 50%, which in this case is 1000-3000ms. I just wonder if 3 seconds is enough given some of the extreme environment that these tests are expected to run in. Also the test doesn't look at the package contents and so the receive will complete if it receives anything. Maybe not for this fix but I assume the test should check that the expected packet is received.

-Alan

Reply via email to