On Sat, Nov 21, 2020 at 10:32:03AM +1100, Cameron Simpson <c...@cskk.id.au> wrote:
> On 19Nov2020 14:14, raf <m...@raf.org> wrote: > >Just a thought: if it needs to have a From_ mbox > >message header (or if it needs to not have that), it > >might be worth mentioning. Even if the mbox message > >header is optional, it might be worth mentioning that > >it's optional. And I think there are several variations > >on the mbox file format (maybe 5?). Which ones, if any, > >are supported? Nothing's ever obvious or trivial, > >especially when it comes to email. :-) > > New ticket for amending the manual entry here: > > https://gitlab.com/muttmua/mutt/-/issues/302 > > Comments on wording/clarity welcome. > > Cheers, > Cameron Simpson <c...@cskk.id.au> In general, I usually think saying "ignored" is ambiguous. Does it mean included but not interpreted as you might expect? Or does it mean skipped? i.e. deleted? That code exerpt from parse.c seems to do something with the From_ header (setting hdr->received to something), so is it really being ignored? Note that I haven't read any other part of parse.c, just that exerpt, so I don't know what I'm talking about. And I think the sentence is a bit back to front for comprehension purposes. Perhaps I'm being silly, but I think it should start by stating what the format is, and then go on to say that's it's flexible about it. How about something like this: The draft file is expected to contain just the email. It is not an mbox file. However, if an mbox From_ header is present, it will be accepted. cheers, raf