Am 14.04.26 um 08:19 schrieb Rene Kita:
On Tue, Apr 14, 2026 at 08:07:10AM +0800, Kevin J. McCarthy wrote:
[...]
I think I'd like to try removing the files from the repos, because if I just
update them again it will merely cause problems yet again in a few years.
Here's what I plan on doing:
1. Fix up the trixie docker image to include autopoint. Just for reference,
I store these in the "docker-images" repository on gitlab:
https://gitlab.com/muttmua/docker-images
2. Add "AM_GNU_GETTEXT_VERSION(0.21)" to configure.ac
3. Remove and gitignore files that are reported as "Copy file" by
`gettextize -f --dry-run --no-changelog`
4. Change prepare script to "autoreconf -isvf". I like the idea of the
symlinks, since it makes it more obvious they are external files.
Any comments? Did I miss a step?
Sounds reasonable.
Matthias, I saw you also posted some fixes to the .gitlab-ci.yml that fixed
the "current directory" assumptions. Would you please send a patch with
that change to this mailing list so Rene can easily review it too?
I fetched the MR, no objections from my side. Two small nits:
(1) I would use more consistent line wrapping in the Makefiles, e.g.:
#v+
+ (find $(top_srcdir) -name \*.sh \
+ && echo "$(srcdir)/gen_defs $(srcdir)/muttbug
$(srcdir)/prepare") \
+ | xargs shellcheck
#v-
(2) Those file name prefixes (Makefile.am:, configure.ac:, CI:) in the
commit messages seem to be unusual for this project.
(1) is really not important.
I wouldn't touch (1) too much as the once-in-a-blue-moon contributor.
Whoever does most hacking on the source gets to set the style, I did not
try to imitate some style to blend in for so small changes.
(2) We can reword commit messages if desired. Just hadn't read much of
commit log context lately.
I'd seen source formatting discussions fly by but stayed out of them, so
if there's something that was agreed on, feel free to point me to the
consensus (if there is one) or just tell me which commit you want
reworked and I'll see to it. I don't want to make adoption/integration
harder than needed.
