On Tue, Apr 14, 2026 at 08:19:31AM +0200, Rene Kita wrote:
I fetched the MR, no objections from my side. Two small nits:
(1) I would use more consistent line wrapping in the Makefiles, e.g.:
#v+
+       (find $(top_srcdir) -name \*.sh \
+               && echo "$(srcdir)/gen_defs $(srcdir)/muttbug 
$(srcdir)/prepare") \
+               | xargs shellcheck
#v-

(2) Those file name prefixes (Makefile.am:, configure.ac:, CI:) in the
  commit messages seem to be unusual for this project.

(1) is really not important.

Ah... I didn't look closely enough at the MR. Sorry Matthias, it looks like you are directly addressing the issue I just complained about. :-D.

The first and third commit in your MR I've already taken care of in my branch, but I'll cherry pick the middle one and send a patchset in a little bit.

--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

Attachment: signature.asc
Description: PGP signature

Reply via email to