On Thu, Apr 11, 2019 at 07:43:46PM -0700, Kevin J. McCarthy wrote:
> On Thu, Apr 11, 2019 at 10:08:56PM -0400, Aaron Schrab wrote:
> > There are already a few uses of __attribute__ in the mutt code; mostly
> > in `intl/` but also one in `monitor.c`.
> The monitor.c use did get through on my review :-/. In that case I let it
> through because it's a linux-only extension, and the code using it is
> straight out of inotify(7). It seemed like it was necessary for correct
> functioning.
Sorry for that...
You already mentioned the manual, were it is taken from the example code
with this comment:
/* Some systems cannot read integer variables if they are not
properly aligned. On other systems, incorrect alignment may
decrease performance. Hence, the buffer used for reading from
the inotify file descriptor should have the same alignment as
struct inotify_event. */
On a first glance alignment is not covered well enough by standards at
this time.
Considering that Mutt doesn't control alignment on other data structures
and there seem to be no issues: Probably it is valid to assume that
compilers as GCC automatically choose a suitable alignment.
Just drop that alignment?
Kind regards,
Gero
