On Thu, Apr 11, 2019 at 10:08:56PM -0400, Aaron Schrab wrote:
There are already a few uses of __attribute__ in the mutt code; mostly in `intl/` but also one in `monitor.c`.
Well, the intl isn't really "mutt code", and the __attribute__ is only for a _LIBC defined function free_mem() in there.
The monitor.c use did get through on my review :-/. In that case I let it through because it's a linux-only extension, and the code using it is straight out of inotify(7). It seemed like it was necessary for correct functioning.
The git codebase also tries to be extremely portable, but it makes a fair amount of use of __attribute__ including this one. For other compilers it does:#ifndef __GNUC__ #ifndef __attribute__ #define __attribute__(x) #endif #endif
Again, I'll say I'm just -0 on this. I have nothing against the idea of adding those warning checks in a portable manner. I'll let others chime in if they have more to say here.
-- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature
