On 11-04-2019 19:43:46 -0700, Kevin J. McCarthy wrote: [snip] > > The git codebase also tries to > >be extremely portable, but it makes a fair amount of use of > >__attribute__ including this one. For other compilers it does: > > > >#ifndef __GNUC__ > >#ifndef __attribute__ > >#define __attribute__(x) > >#endif > >#endif > > Again, I'll say I'm just -0 on this. I have nothing against the idea of > adding those warning checks in a portable manner. I'll let others chime > in if they have more to say here.
Portable? This is a compiler-specific thing. Super useful if you ask me. If you're concerned, how about adding a configure check to see if the compiler groks the construct? Obviously this only makes sense if there is a desire to fix compiler warnings. Especially with GCC-7 and even more with 8, the printf-warnings got much more in volume and annoying (yet correctly pointing out problems). My €0.02 Fabian -- Fabian Groffen Gentoo on a different level
signature.asc
Description: PGP signature
