On 2018-12-18 16:03:38 -0800, Kevin J. McCarthy wrote: > On Tue, Dec 18, 2018 at 01:40:33PM +0100, Vincent Lefevre wrote: > > With the suggestion I've just done in my reply to Derek, I can > > propose for foreground colors: > > > > #colors < 16 >= 16 > > light A_BOLD + 8 > > bright A_BOLD A_BOLD (as currently) > > > > and for background colors, both "light" and "bright" would do a + 8 > > when COLORS >= 8, and nothing otherwise. > > Okay.
I meant COLORS >= 16 obviously. > > Mutt currently has (this was introduced in the initial revision, > > in 1998): > > > > /* A_BLINK turns the background color brite on some terms */ > > *attr |= A_BLINK; > > > > This appears to be for rxvt. I think that this should be removed, > > as in xterm at least, this enables blinking. And rxvt users can > > switch to 256 colors (this is the default, at least under Debian). Both rxvt-unicode and rxvt-unicode-256color have COLORS >= 16 anyway. For the linux console, it is possible to choose linux-16color. BTW, the use of the bright prefix was documented only for foreground colors. > Both of these are fine with me. > > Vincent, I trust you. Feel completely free to send a new patch or even push > up to master if you'd like. If it still needs tweeking we can iterate. :) I've pushed my patch, with documentation. I tried to be rather concise, without giving too many details. Moreover, the "+ 8" is done only when the color number is in the range 0-7. -- Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
