Re: bright colors with GNOME Terminal / 256-color terminals

[Kevin J. McCarthy]

On Tue, Dec 18, 2018 at 01:40:33PM +0100, Vincent Lefevre wrote:

With the suggestion I've just done in my reply to Derek, I can
propose for foreground colors:

#colors      < 16     >= 16
light       A_BOLD     + 8
bright      A_BOLD    A_BOLD    (as currently)

and for background colors, both "light" and "bright" would do a + 8
when COLORS >= 8, and nothing otherwise.

Okay.

Mutt currently has (this was introduced in the initial revision,
in 1998):

     /* A_BLINK turns the background color brite on some terms */
     *attr |= A_BLINK;

This appears to be for rxvt. I think that this should be removed,
as in xterm at least, this enables blinking. And rxvt users can
switch to 256 colors (this is the default, at least under Debian).

Both of these are fine with me.



--
Kevin J. McCarthy
GPG Fingerprint: 8975 A9B3 3AA3 7910 385C  5308 ADEF 7684 8031 6BDA

Vincent, I trust you. Feel completely free to send a new patch or even push up to master if you'd like. If it still needs tweeking we can iterate. :)

signature.asc
Description: PGP signature