On Thu, Dec 10, 2015 at 10:12:37PM -0800, Will Yardley wrote: > On Thu, Dec 10, 2015 at 05:49:40PM -0800, Kevin J. McCarthy wrote: > > What happens with unpatched mutt-1.5.23 if you unset reflow_text? > > However, if I'm understanding the description right, it seems like this > should be ignored like $indent_string (or at least turned off when not > explicitly set) if $text_flowed is unset
It makes sense to ignore $indent_string when $text_flowed is set because the indentation is set by the RFC. $reflow_text is used when displaying (and generating reply text), which are somewhat independent from whether you want to generate flowed emails or not. > ... are there other conditions under which this setting would > be useful? I would think that sending the reply through the > rfc3676_handler when not generating flowed_text would be broken > behavior. It's certainly confusing! But I don't think it's broken. Reflowing might make it easier when replying using fixed width (ignoring the current quoting issue) by allowing you to control the width in the reply yourself (via $reflow_wrap). Also, I think it gives us an opportunity to "fix" the quoting, which you argue next: On Thu, Dec 10, 2015 at 10:27:31PM -0800, Will Yardley wrote: > ps - Given text known to be f=f, I'd also prefer to see the quoted > section like: > > > > > Yay! > > > > > > Noes! > > vs. > > > >> Yay! > > > > > > Noes! > > which is more consistent (and, I think, what the $stuff_all_quoted may > have done). Since with format=flowed text, lines starting with a '>' are > quoted, and the depth is determined by the number of '>' characters, I'm > not sure that the argument that you're reformatting the message in an > unexpected way carries here, but I think that's the argument was last > time this was hashed out. I can understand this if we route through the text_plain_handler() - there we have no business messing with content. But in rfc3676_handler, as you say, the quotes are conceptual. If $text_flowed is unset, I don't see why we couldn't allow for the quotes to be represented differently. A couple ideas come to mind. One might be a boolean setting that adds spaces after each quote at each level. So ">>>Foo" turns into "> > > Foo". Another idea would be a setting that specifies the desired quote string yourself. So, to achieve the same result, you could set it to "> ". Now, the flowed code is fairly tricky, so I can't promise to deliver something like this before 1.6.0, but if this sounds useful, I can at least take a look at it. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA http://www.8t8.us/configs/gpg-key-transition-statement.txt
signature.asc
Description: PGP signature
