Hi Arnt, On Sun, Aug 30, 2015 at 03:27:38PM +0100, Arnt Gulbrandsen wrote: > I'm home, and now have a big-enough screen to see both what I'm typing and > the message to which I reply.
Great! I have no idea how you were able to compose those emails on a tiny screen in the first place. I have a terrible time typing on phones. > > Kevin J. McCarthy writes: > >- Added the unicode logic to the imap_unmunge_mbox_name() call. (I'm > > assuming we shouldn't be trying to utf7 decode strings from the server > > after we've enabled utf8. If this is incorrect, please let me know.) > > It shouldn't matter, or rather, it should matter for mailbox names that > shouldn't occur. But I like your way better. It's cleaner. Thanks for verifying this. I will keep it then. > >- The imap_utf7_encode/decode were also performing conversion from > > the local Charset to UTF-8 before doing the UTF-7 conversion. This > > conversion needs to be performed in either case. > > > > Therefore I renamed them to imap_utf_encode/decode, threaded through > > idata, and put the "if" for utf-7 inside of them. That way the > > Charset conversion will always occur. > > Bit uncertain about the wisdom of trying to support unicode mail on a > terminal that doesn't use unicode... but I guess your change is either > neutral or an improvement, so fine in either case. Okay. My thinking was that some countries still use other charsets by default. Their mailboxes may be in their native language, but would be stored in UTF-8 on the server, so to display them or "change folder" to them, would need to be translated to/from their charset. It doesn't work so well if they try to access a folder in another language, but it wouldn't have worked with UTF-7 either (since we were trying to convert to their Charset too). > >I noticed the decode is taking place twice after a LIST command while > >browsing. I haven't tracked down why yet. > > I noticed that too, but I didn't want to digress in the patch... and anyway > tracking it looked like real work. Yeah, I'll put this on my todo list, and open a bug for it when I have the chance (working on the release this weekend.) -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA http://www.8t8.us/configs/gpg-key-transition-statement.txt
signature.asc
Description: PGP signature
