Hi Ilia, Thanks for finding these errors. I'll have fixes in v2.
- Nanley On Tue, May 19, 2015 at 7:07 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Tue, May 19, 2015 at 8:48 PM, Nanley Chery <nanleych...@gmail.com> > wrote: > > From: Nanley Chery <nanley.g.ch...@intel.com> > > > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > > --- > > .../glapi/gen/KHR_texture_compression_astc.xml | 40 > ++++++++++++++++++++++ > > src/mapi/glapi/gen/Makefile.am | 1 + > > src/mapi/glapi/gen/gl_API.xml | 2 +- > > 3 files changed, 42 insertions(+), 1 deletion(-) > > create mode 100644 src/mapi/glapi/gen/KHR_texture_compression_astc.xml > > > > diff --git a/src/mapi/glapi/gen/KHR_texture_compression_astc.xml > b/src/mapi/glapi/gen/KHR_texture_compression_astc.xml > > new file mode 100644 > > index 0000000..68dbf19 > > --- /dev/null > > +++ b/src/mapi/glapi/gen/KHR_texture_compression_astc.xml > > @@ -0,0 +1,40 @@ > > +<?xml version="1.0"?> > > +<!DOCTYPE OpenGLAPI SYSTEM "gl_API.dtd"> > > + > > +<OpenGLAPI> > > + > > +<category name="GL_KHR_texture_compression_astc_ldr" number="118"> > > + > > + <enum name="COMPRESSED_RGBA_ASTC_4x4_KHR" value = "0x93B0"/> > > I think we use value= everywhere, not value =. Minor point though. > > > + <enum name="COMPRESSED_RGBA_ASTC_5x4_KHR" value = "0x93B1"/> > > + <enum name="COMPRESSED_RGBA_ASTC_5x5_KHR" value = "0x93B2"/> > > + <enum name="COMPRESSED_RGBA_ASTC_6x5_KHR" value = "0x93B3"/> > > + <enum name="COMPRESSED_RGBA_ASTC_6x6_KHR" value = "0x93B4"/> > > + <enum name="COMPRESSED_RGBA_ASTC_8x5_KHR" value = "0x93B5"/> > > + <enum name="COMPRESSED_RGBA_ASTC_8x6_KHR" value = "0x93B6"/> > > + <enum name="COMPRESSED_RGBA_ASTC_8x8_KHR" value = "0x93B7"/> > > + <enum name="COMPRESSED_RGBA_ASTC_10x5_KHR" value = "0x93B8"/> > > + <enum name="COMPRESSED_RGBA_ASTC_10x6_KHR" value = "0x93B9"/> > > + <enum name="COMPRESSED_RGBA_ASTC_10x8_KHR" value = "0x93BA"/> > > + <enum name="COMPRESSED_RGBA_ASTC_10x10_KHR" value = "0x93BB"/> > > + <enum name="COMPRESSED_RGBA_ASTC_12x10_KHR" value = "0x93BC"/> > > + <enum name="COMPRESSED_RGBA_ASTC_12x12_KHR" value = "0x93BD"/> > > + > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_4x4_KHR" value = > "0x93D0"/> > > The spec I'm looking at calls it "COMPRESSED_SRGB8_ALPHA8_ASTC_4x4_KHR". > > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_5x4_KHR" value = > "0x93D1"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_5x5_KHR" value = > "0x93D2"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_6x5_KHR" value = > "0x93D3"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_6x6_KHR" value = > "0x93D4"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_8x5_KHR" value = > "0x93D5"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_8x6_KHR" value = > "0x93D6"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_8x8_KHR" value = > "0x93D7"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x5_KHR" value = > "0x93D8"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x6_KHR" value = > "0x93D9"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x8_KHR" value = > "0x93DA"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_10x10_KHR" value = > "0x93DB"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_12x10_KHR" value = > "0x93DC"/> > > + <enum name="COMPRESSED_SRGB8_ALPHA_8_ASTC_12x12_KHR" value = > "0x93DD"/> > > + > > +</category> > > + > > +</OpenGLAPI> > > diff --git a/src/mapi/glapi/gen/Makefile.am > b/src/mapi/glapi/gen/Makefile.am > > index adebd5c..e0c09ec 100644 > > --- a/src/mapi/glapi/gen/Makefile.am > > +++ b/src/mapi/glapi/gen/Makefile.am > > @@ -185,6 +185,7 @@ API_XML = \ > > INTEL_performance_query.xml \ > > KHR_debug.xml \ > > KHR_context_flush_control.xml \ > > + KHR_texture_compression_astc.xml \ > > NV_conditional_render.xml \ > > NV_primitive_restart.xml \ > > NV_texture_barrier.xml \ > > diff --git a/src/mapi/glapi/gen/gl_API.xml > b/src/mapi/glapi/gen/gl_API.xml > > index 3090b9f..38309a4 100644 > > --- a/src/mapi/glapi/gen/gl_API.xml > > +++ b/src/mapi/glapi/gen/gl_API.xml > > @@ -8162,7 +8162,7 @@ > > > > <xi:include href="ARB_texture_storage.xml" xmlns:xi=" > http://www.w3.org/2001/XInclude"/> > > > > -<!-- ARB extension #118 --> > > +<xi:include href="KHR_texture_compression_astc.xml" xmlns:xi=" > http://www.w3.org/2001/XInclude"/> > > > > <xi:include href="KHR_debug.xml" xmlns:xi=" > http://www.w3.org/2001/XInclude"/> > > > > -- > > 2.4.1 > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
