>Some of these optimizations are pretty obscure and I can't imagine a >real shader hitting them. >
Some of these optimizations are indeed obscure. Only reason I can think of for any of these to succeed are if some other optimizations has pushed constants up the tree, or eliminated things. >What's the cost of checking for these cases? I don't know how expensive >the equals() methods are. > The time it takes to run a shader-db run on my machine has remained pretty constant when adding these. (Within 140 +/- 5 seconds). >Do we want to litter the optimizer with cases that may never be used in >practice? > Obviously we don't want to fill our optimizer with junk. If nobody sees these as useful, then lets not waste more time on them, and get on with more important things. (This mail wll probably not get threaded properly, shitty gmail web interface) -Thomas _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev