On 05/19/2014 10:13 PM, Tapani wrote: > On 05/19/2014 08:21 PM, Ian Romanick wrote: >> Either this patch should: >> >> - Delete the extension enable flag >> - Change the table in extensions.c to use dummy_true >> >> or >> >> The next patch needs to not say "all drivers that support GLSL". >> >> I think we should just enable it everywhere. > > OK, I was following the way how GL_ARB_explicit_attrib_location was > enabled. That one is still only for "all drivers that support GLSL" and > you really need GLSL to be able to use attributes or uniforms. I can > enable it everywhere via dummy_true.
I misread this patch a bit. I think it's okay as long as you also enable the extension in the classic i915 driver. I missed that you were enabling it in Gallium drivers. Oops. > >> On 04/09/2014 02:56 AM, Tapani Pälli wrote: >>> Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> >>> --- >>> src/mesa/drivers/dri/i965/intel_extensions.c | 1 + >>> src/mesa/state_tracker/st_extensions.c | 1 + >>> 2 files changed, 2 insertions(+) >>> >>> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c >>> b/src/mesa/drivers/dri/i965/intel_extensions.c >>> index 15fcd30..f8abf98 100644 >>> --- a/src/mesa/drivers/dri/i965/intel_extensions.c >>> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c >>> @@ -170,6 +170,7 @@ intelInitExtensions(struct gl_context *ctx) >>> ctx->Extensions.ARB_draw_instanced = true; >>> ctx->Extensions.ARB_ES2_compatibility = true; >>> ctx->Extensions.ARB_explicit_attrib_location = true; >>> + ctx->Extensions.ARB_explicit_uniform_location = true; >>> ctx->Extensions.ARB_fragment_coord_conventions = true; >>> ctx->Extensions.ARB_fragment_program = true; >>> ctx->Extensions.ARB_fragment_program_shadow = true; >>> diff --git a/src/mesa/state_tracker/st_extensions.c >>> b/src/mesa/state_tracker/st_extensions.c >>> index 3e1e45d..5b11e7b 100644 >>> --- a/src/mesa/state_tracker/st_extensions.c >>> +++ b/src/mesa/state_tracker/st_extensions.c >>> @@ -534,6 +534,7 @@ void st_init_extensions(struct st_context *st) >>> ctx->Extensions.ARB_ES2_compatibility = GL_TRUE; >>> ctx->Extensions.ARB_draw_elements_base_vertex = GL_TRUE; >>> ctx->Extensions.ARB_explicit_attrib_location = GL_TRUE; >>> + ctx->Extensions.ARB_explicit_uniform_location = GL_TRUE; >>> ctx->Extensions.ARB_fragment_coord_conventions = GL_TRUE; >>> ctx->Extensions.ARB_fragment_program = GL_TRUE; >>> ctx->Extensions.ARB_fragment_shader = GL_TRUE; >>> > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
