Paul Berry <stereotype...@gmail.com> writes: > This patch moves the following data structures from vec4_visitor to > vec4_vs_visitor, since they contain VS-specific data: > > - struct brw_vs_compile *c > - struct brw_vs_prog_data *prog_data > - src_reg *vp_temp_regs > - src_reg vp_addr_reg > > Since brw_vs_compile and brw_vs_prog_data also contain vec4-generic > data, the following pointers are added to the base class, to allow it > to access the vec4-generic portions of these data structures: > > - struct brw_vec4_compile *vec4_compile > - struct brw_vec4_prog_key *vec4_key > - struct brw_vec4_prog_data *vec4_prog_data
I would lean toward the base class (which contains most of the members and usages, I think) having the short name, and the derived class having the more specific name. Either way, patch 7-11 are: Reviewed-by: Eric Anholt <e...@anholt.net>
pgp6KftuxloEV.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev