On 09/28/2012 01:28 PM, Eric Anholt wrote: > Oliver McFadden <oliver.mcfad...@linux.intel.com> writes: > >> Split the perf_debug() messages into performance debugging information >> which may be useful for application developers or driver developers. >> >> Always print the information useful for application developers on the >> Android platform. >> >> Signed-off-by: Oliver McFadden <oliver.mcfad...@linux.intel.com> >> CC: Chad Versace <chad.vers...@linux.intel.com> >> --- >> v2: Split perf_debug() into app/driver specific messages; try to only print >> useful debug information to the application developer. >> >> Chad, I'd like your opinion on whether I have split the app/driver messages >> roughly correctly. Thanks! > > I don't think you want to split these. As an app dev, do want to know > when you're recompiling shaders or mapping busy BOs. (Busy BOs is like > the most important thing in perf_debug for you!)
Agreed. All messages are useful for both classes of developers. Even if an application developer can't do anything about a particular message, it's at least useful to tell them that they're hitting a slow path in our driver and suffering as a consequence. Driver developers want to see everything. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
