[Mesa-dev] [PATCH 02/15] ac: simplify LLVM alloca helpers

[Marek Olšák]

From: Marek Olšák <marek.ol...@amd.com>

---
 src/amd/common/ac_llvm_build.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 4cbf599d946..fc6dc396d38 100644
--- a/src/amd/common/ac_llvm_build.c
+++ b/src/amd/common/ac_llvm_build.c
@@ -2801,50 +2801,47 @@ void ac_build_if(struct ac_llvm_context *ctx, 
LLVMValueRef value,
 
 void ac_build_uif(struct ac_llvm_context *ctx, LLVMValueRef value,
                  int label_id)
 {
        LLVMValueRef cond = LLVMBuildICmp(ctx->builder, LLVMIntNE,
                                          ac_to_integer(ctx, value),
                                          ctx->i32_0, "");
        if_cond_emit(ctx, cond, label_id);
 }
 
-LLVMValueRef ac_build_alloca(struct ac_llvm_context *ac, LLVMTypeRef type,
+LLVMValueRef ac_build_alloca_undef(struct ac_llvm_context *ac, LLVMTypeRef 
type,
                             const char *name)
 {
        LLVMBuilderRef builder = ac->builder;
        LLVMBasicBlockRef current_block = LLVMGetInsertBlock(builder);
        LLVMValueRef function = LLVMGetBasicBlockParent(current_block);
        LLVMBasicBlockRef first_block = LLVMGetEntryBasicBlock(function);
        LLVMValueRef first_instr = LLVMGetFirstInstruction(first_block);
        LLVMBuilderRef first_builder = LLVMCreateBuilderInContext(ac->context);
        LLVMValueRef res;
 
        if (first_instr) {
                LLVMPositionBuilderBefore(first_builder, first_instr);
        } else {
                LLVMPositionBuilderAtEnd(first_builder, first_block);
        }
 
        res = LLVMBuildAlloca(first_builder, type, name);
-       LLVMBuildStore(builder, LLVMConstNull(type), res);
-
        LLVMDisposeBuilder(first_builder);
-
        return res;
 }
 
-LLVMValueRef ac_build_alloca_undef(struct ac_llvm_context *ac,
+LLVMValueRef ac_build_alloca(struct ac_llvm_context *ac,
                                   LLVMTypeRef type, const char *name)
 {
-       LLVMValueRef ptr = ac_build_alloca(ac, type, name);
-       LLVMBuildStore(ac->builder, LLVMGetUndef(type), ptr);
+       LLVMValueRef ptr = ac_build_alloca_undef(ac, type, name);
+       LLVMBuildStore(ac->builder, LLVMConstNull(type), ptr);
        return ptr;
 }
 
 LLVMValueRef ac_cast_ptr(struct ac_llvm_context *ctx, LLVMValueRef ptr,
                          LLVMTypeRef type)
 {
        int addr_space = LLVMGetPointerAddressSpace(LLVMTypeOf(ptr));
        return LLVMBuildBitCast(ctx->builder, ptr,
                                LLVMPointerType(type, addr_space), "");
 }
-- 
2.17.1

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev