Quoting Lionel Landwerlin (2017-11-01 14:25:03) > On 01/11/17 20:30, Dylan Baker wrote: > > Quoting Scott D Phillips (2017-11-01 10:30:09) > >> Lionel Landwerlin <lionel.g.landwer...@intel.com> writes: > >> > >>> On 31/10/17 21:11, Scott D Phillips wrote: > >>>>> +} > >>>> [snip imgui] > >>>> > >>>> imgui seems to be the first instance of someone pasting a sizeable third > >>>> party library into the repo. I'm not sure how everyone feels about > >>>> that. Unfortunately it seems like imgui isn't packaged by any distros > >>>> that I can see either. > >>>> > >>>> Maybe we could do some meson wrap magic or something to pull it in > >>>> without having to commit the code. > >>>> > >>> Copying seems to be the main way anybody is using it. Are you suggesting > >>> a submodule? > >> Right, something like making a 'wrap' for imgui that can go download and > >> build the source: > >> > >> http://mesonbuild.com/Wrap-dependency-system-manual.html > >> > >> Really no idea if this is a great or terrible idea though. Dylan might > >> have a better idea. > >> > >>> _______________________________________________ > >>> mesa-dev mailing list > >>> mesa-dev@lists.freedesktop.org > >>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > I'm really not thrilled with the idea of pulling such a large fast moving > > project into the tree either, though there is president, we have gtest in > > tree > > already. > > > > A wrap might be a good way to build it it, especially for an optional tool > > that > > distros aren't expected to package. I wonder if upstream would take a meson > > build > > specifically for this purpose? Would you like me to follow up with them and > > see > > if that would be an option (meson feels [rightly] that it's preferable to > > try to > > get a meson build into the upstream project before adding it to wrapdb)? > > > > Dylan > > I'll ask but it seems the ImGui project is really not meant to be > packaged like most software we find in Linux distros. > There are a few glue example to work on various versions window systems > and OpenGL/Vulkan, but these are just meant as examples. > It's expected whoever uses it will embedded it in its project and tweak > the few things it needs (either event plumbing or adding new > colors-scheme/widgets). > > In our case, I wrote the Gtk3 backend, I'm pretty sure there is little > interest in having it upstream. > > - > Lionel
At least I'm not concerned with having the gtk backend in tree, I'm concerned with vendoring the upstream project in tree. I'm pretty much convinced that vendoring is always a bad idea. I do have a working meson wrap for imgui, it's 40 lines of meson with an MIT copyright header, and only provides a static library for the cpp files and an include directive for the h files, you can see it here: https://github.com/dcbaker/imgui wip/meson-wrap If upstream isn't interested in it, we could get into meson's wrap-db, although that doesn't solve the problem that it needs to be built with autotools for the forseeable future. Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
