On 25/04/17 01:43 AM, Nicolai Hähnle wrote: > On 24.04.2017 18:32, Marek Olšák wrote: >> On Mon, Apr 24, 2017 at 5:34 PM, Nicolai Hähnle <nhaeh...@gmail.com> >> wrote: >>> On 24.04.2017 15:22, Marek Olšák wrote: >>>> >>>> From: Marek Olšák <marek.ol...@amd.com> >>> >>> >>> I don't like it. This kind of app-specific override is what drirc was >>> meant >>> to provide. Having separate places for it is confusing. >> >> The question is: would other drivers want this code in st_draw_vbo? >> For threaded gallium, we shouldn't put more stuff into st_draw_vbo. >> >> Alternatively, it can be a flag for pipe_screen::context_create to >> enable this behavior in radeonsi and keep the list in drirc. > > Is there a particular reason we can't let radeonsi (and other gallium > drivers) access drirc directly?
Yeah, something like that would be a better approach. This patch is too hackish. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
