On 04/24/2017 06:32 PM, Marek Olšák wrote:
On Mon, Apr 24, 2017 at 5:34 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote:
On 24.04.2017 15:22, Marek Olšák wrote:
From: Marek Olšák <marek.ol...@amd.com>
I don't like it. This kind of app-specific override is what drirc was meant
to provide. Having separate places for it is confusing.
The question is: would other drivers want this code in st_draw_vbo?
For threaded gallium, we shouldn't put more stuff into st_draw_vbo.
Alternatively, it can be a flag for pipe_screen::context_create to
enable this behavior in radeonsi and keep the list in drirc.
I do agree with Nicolai, it would be nice to avoid adding app-specific
workarounds directly in the driver.
Maybe you can add a new function in pipe_screen, like
set_context_options() with a new flag or something? There are many
get_XXX() functions there, maybe it makes sense to add a set_something().
Marek
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
