1-27/42 and 29-42/42 are Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net>
28/42 will take more brain power than I can exert tonight. I'll look at it tomorrow. Thanks for working on this. I know how much pain refactoring can be. On Wed, Oct 19, 2016 at 4:09 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > V3: > - create a temporary copy_shader_info() helper and split up the changes > in this series for easier review as suggested by Jason/Ken. > - a couple of small changes as suggested by Ian and Marek (more details in > patches). > > Having the shader info struct in nir_shader makes things difficult for > the shader cache, and means we are copying values in the glsl->nir pass > unnecessarily. This series creates a shared shader info and makes a bunch > of clean-ups based on this change. > > The st changes have been tested against llvmpipe. > > There is still more work to be done to remove some of the now duplicate > fields in gl_program but I'll send that in a follow up series. > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
