-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/04/2011 12:20 PM, Ian Romanick wrote: > On 10/04/2011 10:49 AM, Paul Berry wrote: >> On 4 October 2011 10:32, Chad Versace <c...@chad-versace.us >> <mailto:c...@chad-versace.us>> wrote: >> >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Overall, the patch looks good, but I'm going to take the bikeshed bait. >> >> Symbols of form GLxxx and constants of form GL_XXX should be >> reserved for >> those defined in the GL headers. If I encountered the symbol GLclipplane >> in Mesa, I would confidently, yet incorrectly, assume the symbol was >> defined in some GL extension of which I was unaware. > > You mean like GLstencil and GLbitfield64? :)
YES!!! GLbitfield64 is the guilty typedef I had in mind. > >> Typically, when we wish a symbol name to be closely related to it GL >> analogue, >> we use one of the following naming schemes: >> fuctions: _mesa_CamelCaps, intel_no_caps >> struct: gl_no_caps >> enums: gl_no_caps >> constants: MESA_XXX >> >> For examples: >> _mesa_BindFramebufferEXT(), intel_bind_framebuffer() >> struct gl_framebuffer >> enum gl_format >> MESA_FORMAT_RGBA8888 >> >> >> Ok, I'm fine with this. Unless someone has a better suggestion, I >> propose renaming "GLclipplane" to "gl_clip_plane". Would that address >> your concerns, Chad? > > That would work for me. It works for me too. Thanks for changing it. Reviewed-by: Chad Versace <c...@chad-versace.us> - -- Chad Versace c...@chad-versace.us -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOi3ISAAoJEAIvNt057x8igHoP/2v56RfCt11Y0u81f3OPcoh+ N0oCYEj0aWxyJSLMoJ06v6LokIibmSqkZrqooJzkzpfaozPCtmL03m59Os+O8pnJ MMoEiHZwF3YY6KnrMjeOVvLwTmuaVVSw2AWiW3VIl8lkOoleESB5Sqa+1QjpP9es TOPxJ250XoVGBeq+9YYLA7xA8xaxF2bsqRJ1SxqCDcQ7oG7NzUGfw+acgy7PtpkC gbM7Uqlf8eIgAgSG3YOX6N7s/5cQ9DQv0Wx8FgS/wCYqZBYrJTXc1iehFQJX1M6x JAqwPIe/EoPAaOqaidmQBpOJ73Wpv6IobTy6+kD1c0ltzkkNaKiPBScCkVVvIK/G ge3k4dOl0RvluAVFBuTpGk3wPUcnL6bE+94G8jPINaXTWWgPbbqlzZRWSxmvZX8S qXWxlKhHOlhhzf04xmyzUWhVO8HLm58BeyRMEMz3Qa6P0RUribPVxUF2UHYmjdsE 2iirfMGPOs5gIaO6yP5X0YK0r2yZdylppr9QlGgY4lelSQOnqpdfCjorL5v/h3p7 Vo1UxWn1MYk7JgpaE3oCnAwIs6b+HbIkRSNCn2IQ4oMmWOudehDbMz4AmMCozwGJ 3DkS/2WQXrnCdb/XDTpy7p/PABVAlrNssQDhiqUC5TxcCbEQHK1jdXDcMfcYEwu7 TSvnLb3bMdhSo1YKV5Hi =XOXH -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
