Re: [Mesa-dev] [PATCH v2 21/27] i965/blorp/clear: Move isl_surf setup higher in the function

[Pohjolainen, Topi]

On Tue, Jul 26, 2016 at 03:11:25PM -0700, Jason Ekstrand wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

Patches 20 and 21 (preparing for patch 23) are:

Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com>

> 
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp 
> b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> index a66e955..cb288de 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp
> @@ -201,16 +201,6 @@ do_single_blorp_clear(struct brw_context *brw, struct 
> gl_framebuffer *fb,
>        is_fast_clear = true;
>     }
>  
> -   if (is_fast_clear) {
> -      memset(&params.wm_inputs, 0xff, 4*sizeof(float));
> -      params.fast_clear_op = GEN7_PS_RENDER_TARGET_FAST_CLEAR_ENABLE;
> -
> -      brw_get_fast_clear_rect(brw, irb->mt, &params.x0, &params.y0,
> -                              &params.x1, &params.y1);
> -   }
> -
> -   brw_blorp_params_get_clear_kernel(brw, &params, 
> use_simd16_replicated_data);
> -
>     intel_miptree_check_level_layer(irb->mt, irb->mt_level, layer);
>     intel_miptree_used_for_rendering(irb->mt);
>  
> @@ -222,6 +212,16 @@ do_single_blorp_clear(struct brw_context *brw, struct 
> gl_framebuffer *fb,
>                                 brw_blorp_to_isl_format(brw, format, true),
>                                 true);
>  
> +   if (is_fast_clear) {
> +      memset(&params.wm_inputs, 0xff, 4*sizeof(float));
> +      params.fast_clear_op = GEN7_PS_RENDER_TARGET_FAST_CLEAR_ENABLE;
> +
> +      brw_get_fast_clear_rect(brw, irb->mt, &params.x0, &params.y0,
> +                              &params.x1, &params.y1);
> +   }
> +
> +   brw_blorp_params_get_clear_kernel(brw, &params, 
> use_simd16_replicated_data);
> +
>     const char *clear_type;
>     if (is_fast_clear)
>        clear_type = "fast";
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev