On Fri, Jan 29, 2016 at 3:05 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > Both for this and the previous patch, should we start advertising the > relevant EGL extensions as well? Or would that take more effort than > just not returning errors for them?
That is what patch 5 does. It seems to work just advertising the extensions. Rob > On Fri, Jan 29, 2016 at 3:51 PM, Rob Herring <r...@kernel.org> wrote: >> This is a necessary attribute on Android M. >> >> Signed-off-by: Rob Herring <r...@kernel.org> >> --- >> src/egl/main/eglconfig.c | 4 +++- >> src/egl/main/eglconfig.h | 2 ++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c >> index 0e0058f..df3a66b 100644 >> --- a/src/egl/main/eglconfig.c >> +++ b/src/egl/main/eglconfig.c >> @@ -250,9 +250,11 @@ static const struct { >> { EGL_FRAMEBUFFER_TARGET_ANDROID, ATTRIB_TYPE_BOOLEAN, >> ATTRIB_CRITERION_EXACT, >> EGL_DONT_CARE }, >> + { EGL_RECORDABLE_ANDROID, ATTRIB_TYPE_BOOLEAN, >> + ATTRIB_CRITERION_EXACT, >> + EGL_DONT_CARE }, >> }; >> >> - >> /** >> * Return true if a config is valid. When for_matching is true, >> * EGL_DONT_CARE is accepted as a valid attribute value, and checks >> diff --git a/src/egl/main/eglconfig.h b/src/egl/main/eglconfig.h >> index 7bdb090..22da697 100644 >> --- a/src/egl/main/eglconfig.h >> +++ b/src/egl/main/eglconfig.h >> @@ -87,6 +87,7 @@ struct _egl_config >> /* extensions */ >> EGLint YInvertedNOK; >> EGLint FramebufferTargetAndroid; >> + EGLint RecordableAndroid; >> }; >> >> >> @@ -135,6 +136,7 @@ _eglOffsetOfConfig(EGLint attr) >> /* extensions */ >> ATTRIB_MAP(EGL_Y_INVERTED_NOK, YInvertedNOK); >> ATTRIB_MAP(EGL_FRAMEBUFFER_TARGET_ANDROID, FramebufferTargetAndroid); >> + ATTRIB_MAP(EGL_RECORDABLE_ANDROID, RecordableAndroid); >> #undef ATTRIB_MAP >> default: >> return -1; >> -- >> 2.5.0 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev