On 01/11/2011 11:20 AM, Ian Romanick wrote:
> On 01/09/2011 11:53 PM, Chad Versace wrote:
>> + { "GL_OES_framebuffer_object",
>> o(ARB_framebuffer_object), ES1 },
>
> I think this and the other OES framebuffer object related extensions
> should depend on EXT_framebuffer_object.
>
>> + { "GL_OES_point_sprite", o(dummy_true),
>> ES1 },
>
> This should depend on GL_ARB_point_sprite.
Done. I've amended patch 1/2 with the attached patch.
>> + { "GL_OES_standard_derivatives", o(ARB_fragment_shader),
>> ES2 },
>
> This should be a stand-alone extension. We have some hardware (i.e.,
> r300 and i915) that advertises support for ARB_fragment_shader but
> cannot do the partial derivatives.
struct gl_extensions (in src/mesa/main/mtypes.h) does not a member for
OES_standard_derivatives. Is the proper action here to add that member,
and then let drivers selectively enable it? Or to add that member, and
always enable it by default?
--
Chad Versace
chad.vers...@intel.com
c...@chad-versace.us
--
src/mesa/main/extensions.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index 851bf9e..aebabcf 100644
--- a/src/mesa/main/extensions.c
+++ b/src/mesa/main/extensions.c
@@ -209,7 +209,7 @@ static const struct extension extension_table[] = {
{ "GL_OES_blend_subtract", o(EXT_blend_subtract),
ES1 },
{ "GL_OES_byte_coordinates", o(dummy_true),
ES1 },
{ "GL_OES_compressed_paletted_texture", o(dummy_false),
DISABLE },
- { "GL_OES_depth24", o(ARB_framebuffer_object),
ES1 | ES2 },
+ { "GL_OES_depth24", o(EXT_framebuffer_object),
ES1 | ES2 },
{ "GL_OES_depth32", o(dummy_false),
DISABLE },
{ "GL_OES_depth_texture", o(ARB_depth_texture),
ES2 },
#if FEATURE_OES_draw_texture
@@ -220,22 +220,22 @@ static const struct extension extension_table[] = {
{ "GL_OES_EGL_image", o(OES_EGL_image),
GL | ES1 | ES2 },
#endif
{ "GL_OES_element_index_uint", o(EXT_vertex_array),
ES1 | ES2 },
- { "GL_OES_fbo_render_mipmap", o(ARB_framebuffer_object),
ES1 | ES2 },
+ { "GL_OES_fbo_render_mipmap", o(EXT_framebuffer_object),
ES1 | ES2 },
{ "GL_OES_fixed_point", o(dummy_true),
ES1 },
- { "GL_OES_framebuffer_object", o(ARB_framebuffer_object),
ES1 },
+ { "GL_OES_framebuffer_object", o(EXT_framebuffer_object),
ES1 },
{ "GL_OES_mapbuffer",
o(ARB_vertex_buffer_object), ES1 | ES2 },
{ "GL_OES_matrix_get", o(dummy_true),
ES1 },
{ "GL_OES_packed_depth_stencil",
o(EXT_packed_depth_stencil), ES1 | ES2 },
{ "GL_OES_point_size_array", o(dummy_true),
ES1 },
- { "GL_OES_point_sprite", o(dummy_true),
ES1 },
+ { "GL_OES_point_sprite", o(ARB_point_sprite),
ES1 },
{ "GL_OES_query_matrix", o(dummy_true),
ES1 },
{ "GL_OES_read_format", o(OES_read_format),
GL | ES1 },
- { "GL_OES_rgb8_rgba8", o(ARB_framebuffer_object),
ES1 | ES2 },
+ { "GL_OES_rgb8_rgba8", o(EXT_framebuffer_object),
ES1 | ES2 },
{ "GL_OES_single_precision", o(dummy_true),
ES1 },
{ "GL_OES_standard_derivatives", o(ARB_fragment_shader),
ES2 },
{ "GL_OES_stencil1", o(dummy_false),
DISABLE },
{ "GL_OES_stencil4", o(dummy_false),
DISABLE },
- { "GL_OES_stencil8", o(ARB_framebuffer_object),
ES1 | ES2 },
+ { "GL_OES_stencil8", o(EXT_framebuffer_object),
ES1 | ES2 },
{ "GL_OES_stencil_wrap", o(EXT_stencil_wrap),
ES1 },
/* GL_OES_texture_3D is disabled due to missing GLSL support. */
{ "GL_OES_texture_3D", o(EXT_texture3D),
DISABLE },
--
1.7.3.3
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
