hi Karan,
this looks like a very good start! There are a few things that should be changed and I listed them below (some of them common to all three ports): 1) you’re missing the “license” field (you should have gotten a warning about this when doing “port lint —nitpick py-upt”) 2) the value for “homepage” seems incorrect 3) since upt is a tool (i.e., run on the command line and not really used as a library by other packages) only one Python version would suffice. I'd suggest to only add “37” after “python.versions” 4) the category of your dependencies is not completely correct. Indeed, py-setuptools is a build-dependency, but py-spdx-lookup is not. The latter is needed when using upt and should, therefore, be listed as “depends_lib-append”. 5) please add "supported_archs noarch” after “platforms"; since there are no architecture dependent files installed (as is often the case for Python scripts) 6) a little bit nitpicking: (i) add a new line after the modeline, (2) add “revision 0” after “version” I do agree with adding ports for the frontends and macports-backend. I suppose these should be all installed by default in the py-upt port since the program isn’t very useful otherwise); one could also add variants but I am not sure if that’s all that useful in this case. Best, Renee > On Apr 5, 2019, at 2:25 AM, KARAN SHETH <karan.sh...@somaiya.edu> wrote: > > Hey, > > So I tried porting upt and in the process had to port spdx-lookup and spdx. > These are the portfiles for the same [1],[2],[3]. > > When I try to install upt there is no error message but while trying > to run upt via a terminal directly it says the command not found > whereas if I go to python console and import upt, then it works as expected. > I guess the problem is related to sys.path > > It would be great if someone could try installing upt using this > portfiles and check if there's any error. > > Thanks, > Karan Sheth. > > [1] > https://github.com/Korusuke/macports-ports/blob/9d7f1995dfb44f693f90a79f91d8695b9dd7feac/python/py-upt/Portfile > [2] > https://github.com/Korusuke/macports-ports/blob/9d7f1995dfb44f693f90a79f91d8695b9dd7feac/python/py-spdx-lookup/Portfile > [3] > https://github.com/Korusuke/macports-ports/blob/9d7f1995dfb44f693f90a79f91d8695b9dd7feac/python/py-spdx/Portfile > > On Tue, Apr 2, 2019 at 6:11 AM Renee Otten <ottenr.w...@gmail.com> wrote: >> >> >> I generated a portfile for py-upt and tried installing that after a few >> manual edits, which will actually be automated in the future. >> It did install properly without any errors but I guess there's some issue >> with the path and because of which it was unuseable, once I figure this out >> should I make a PR ? >> >> >> Great - you can certainly submit a PR when you have a (mostly) working >> version. >> >> Path where pip installs : >> /Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages >> Path where macports installs : >> ./opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages >> >> >> The install path (without the “dot” in front) seems fine. It would probably >> be useful for you to take a look at the MacPorts guide >> (https://guide.macports.org/) and, more specifically, Chapter 5. >> >> Am I missing anything obvious here cause I have no prior experience >> installing local ports. >> >> That’s hard to tell without looking at the Portfile and/or trying it. You >> can submit a PR and get feedback over there or, if you’d like some >> suggestions before submitting a PR, just point us to your Portfile (I >> couldn’t find a clone of the macports-port repository on your GitHub). >> >> Best, >> Renee > > -- > > <https://www.somaiya.edu> <http://www.somaiya-ayurvihar.org> > <http://nareshwadi.org> <http://somaiya.com> <http://www.helpachild.in> > <http://nareshwadi.org>
